Comments on: DoubleDawg 1: A Quick Tour

By: Jeff Grigg

Jeff Grigg — Mon, 11 Jan 2010 22:46:23 +0000

I checked: The “AnnotationUtils.resolvePropertyName(…)” is called from only one place (class XWorkConverter). …until we change our code to call it. Then it’s called from two places.

Code reuse in action!!! ;->

By: GeePawHill

GeePawHill — Mon, 11 Jan 2010 18:37:57 +0000

Jeff,
I also saw that static. The best local fix is the one you did. I wonder if it’s called from all over? It may not even be used elsewhere.
– GeePawHill

By: Jeff Grigg

Jeff Grigg — Sun, 10 Jan 2010 15:40:19 +0000

The public “resolvePropertyName” method bugs me. I so want to make it static.

So I did some digging. Turns out the exact same code is in a public static method in the “AnnotationUtils” class. It’s used by the XWorkConverter class.

Quick change:
“ResolvePropertyName(…)” to “AnnotationUtils.resolvePropertyName(…)”.
Then I run all of my new tests for AnnotationValidationConfigurationBuilder. They all pass. Then I delete the method from AVCB, and the two static constants.

Done:
Now AnnotationValidationConfigurationBuilder has only a single public method. And it’s the method that does the real work of the class.

By: GeePawHill

GeePawHill — Sat, 09 Jan 2010 16:17:46 +0000

Good idea. It’s on the doubledawg tab!

By: Jeff Grigg

Jeff Grigg — Sat, 09 Jan 2010 13:48:19 +0000

Could you export your GeePawHill eclipse formatter (to XML) and upload it, to make it available to us students of knowledge who are following along?

Thanks!

By: More Signal – Less Noise « Maximising Signal

More Signal – Less Noise « Maximising Signal — Tue, 01 Sep 2009 22:25:34 +0000

[...] has an excellent series of posts going on down at the creek, and in this one he said something which struck a chord. He cleaned up all the warnings in a class to ensure that [...]