Comments on: DoubleDawgDare 5: Pick, Pick, Pick http://anarchycreek.com/2009/10/26/doubledawgdare-5-pick-pick-pick/ Towards a Way of Excellence Wed, 28 Jul 2010 00:38:53 +0000 hourly 1 http://wordpress.org/?v=3.0.1 By: Jeff Grigg http://anarchycreek.com/2009/10/26/doubledawgdare-5-pick-pick-pick/comment-page-1/#comment-792 Jeff Grigg Sat, 09 Jan 2010 13:43:27 +0000 http://anarchycreek.com/?p=882#comment-792 (I see that the code duplication in the “processValidationAnnotationSingular” method was introduced when you did the “process*Annotation” inlines. Darn; I hate it when I do things like that! ;-) (I see that the code duplication in the “processValidationAnnotationSingular” method was introduced when you did the “process*Annotation” inlines. Darn; I hate it when I do things like that! ;-)

]]> By: Jeff Grigg http://anarchycreek.com/2009/10/26/doubledawgdare-5-pick-pick-pick/comment-page-1/#comment-791 Jeff Grigg Sat, 09 Jan 2010 13:00:21 +0000 http://anarchycreek.com/?p=882#comment-791 I noticed that the code in the “processValidationAnnotationSingular” method contains copies of the code in nearly all of the other “process*” methods. (Everything except DoubleRangeFieldValidator.) I would suggest deleting the unnecessary null checks from that code, and then for each “process*Validator” method, extract all the lines except the first into a method of the same name, and then inline the original method (back into the processSingleAnnotation method). I think you’ll like the effect this will have on the processValidationAnnotationSingular/processValidations method. I noticed that the code in the “processValidationAnnotationSingular” method contains copies of the code in nearly all of the other “process*” methods. (Everything except DoubleRangeFieldValidator.) I would suggest deleting the unnecessary null checks from that code, and then for each “process*Validator” method, extract all the lines except the first into a method of the same name, and then inline the original method (back into the processSingleAnnotation method). I think you’ll like the effect this will have on the processValidationAnnotationSingular/processValidations method.

]]> By: Jeff Grigg http://anarchycreek.com/2009/10/26/doubledawgdare-5-pick-pick-pick/comment-page-1/#comment-790 Jeff Grigg Sat, 09 Jan 2010 12:59:50 +0000 http://anarchycreek.com/?p=882#comment-790 I notice that... Validation -> processValidationPlural Validations -> processValidationAnnotationSingular (annotation name -> goes to -> method name) So “Validation” is Plural, while “ValidationSSS” is Singular? To be more consistent with the other methods, I would probably call them “processValidation” and “processValidations”. I notice that…
Validation -> processValidationPlural
Validations -> processValidationAnnotationSingular
(annotation name -> goes to -> method name)

So “Validation” is Plural, while “ValidationSSS” is Singular?

To be more consistent with the other methods, I would probably call them “processValidation” and “processValidations”.

]]> By: Jeff Grigg http://anarchycreek.com/2009/10/26/doubledawgdare-5-pick-pick-pick/comment-page-1/#comment-789 Jeff Grigg Sat, 09 Jan 2010 12:59:24 +0000 http://anarchycreek.com/?p=882#comment-789 Looking through the class, I too have a very strong feeling that I would create a wrapper class for each annotation class, give them a common abstract base class, and then use reflection to find and create them and dispatch to them. [Sorry; replied to wrong thread with previous post.] Looking through the class, I too have a very strong feeling that I would create a wrapper class for each annotation class, give them a common abstract base class, and then use reflection to find and create them and dispatch to them.

[Sorry; replied to wrong thread with previous post.]

]]> By: Jeff Grigg http://anarchycreek.com/2009/10/26/doubledawgdare-5-pick-pick-pick/comment-page-1/#comment-788 Jeff Grigg Sat, 09 Jan 2010 12:57:30 +0000 http://anarchycreek.com/?p=882#comment-788 Looking through the class, I too have a very strong feeling that I would create a wrapper class for each annotation class, give them a common abstract base class, and then use reflection to find and create them and dispatch to them. Looking through the class, I too have a very strong feeling that I would create a wrapper class for each annotation class, give them a common abstract base class, and then use reflection to find and create them and dispatch to them.

]]> By: Refactoring: Getting DoubleDawg To Remember Its Type Info | Situated Geekery http://anarchycreek.com/2009/10/26/doubledawgdare-5-pick-pick-pick/comment-page-1/#comment-787 Refactoring: Getting DoubleDawg To Remember Its Type Info | Situated Geekery Sat, 09 Jan 2010 03:25:21 +0000 http://anarchycreek.com/?p=882#comment-787 [...] Next DoubleDawgDare [...] [...] Next DoubleDawgDare [...]

]]> By: GeePawHill http://anarchycreek.com/2009/10/26/doubledawgdare-5-pick-pick-pick/comment-page-1/#comment-502 GeePawHill Sun, 08 Nov 2009 00:33:36 +0000 http://anarchycreek.com/?p=882#comment-502 The double-dispatch provided by Visitor would be nice, though we can't really add methods to the annotation-derived class, and we'd need a 'VisitMe' method. I think of Visitor as being always applied to tree-like structures, but of course it can operate on any heterogeneous collection. What if we had an adapter around the annotation and *it* had the VisitMe call? That would feel good if we didn't have to write an adapter for every annotation. Will think on it. The double-dispatch provided by Visitor would be nice, though we can’t really add methods to the annotation-derived class, and we’d need a ‘VisitMe’ method. I think of Visitor as being always applied to tree-like structures, but of course it can operate on any heterogeneous collection.
What if we had an adapter around the annotation and *it* had the VisitMe call? That would feel good if we didn’t have to write an adapter for every annotation. Will think on it.

]]> By: GeePawHill http://anarchycreek.com/2009/10/26/doubledawgdare-5-pick-pick-pick/comment-page-1/#comment-501 GeePawHill Sun, 08 Nov 2009 00:30:31 +0000 http://anarchycreek.com/?p=882#comment-501 Altogether it takes around six or seven hours. The first hour is usually all I need to decide where the refactorings are headed. Then I make the video. Oddly, I can't seem to rehearse: if the camera isn't rolling I don't have the tingle of fear that gives me energy! I usually shoot about three times before I have something I like. Editing the video takes about two hours. That's just editing for sound, I don't re-organize the content or change what I'm doing. Friends at IL are happier with a "shoot-a-llitle-edit-a-little" approach, but I can't seem to make that work for me. It's fun to do. This one's hard because of the damned annotation stuff: we could trivially move the handlers onto a tree of handlers if we could just control how the annotation is derived. A little extra challenge. :) Altogether it takes around six or seven hours. The first hour is usually all I need to decide where the refactorings are headed. Then I make the video. Oddly, I can’t seem to rehearse: if the camera isn’t rolling I don’t have the tingle of fear that gives me energy! I usually shoot about three times before I have something I like. Editing the video takes about two hours. That’s just editing for sound, I don’t re-organize the content or change what I’m doing. Friends at IL are happier with a “shoot-a-llitle-edit-a-little” approach, but I can’t seem to make that work for me.

It’s fun to do. This one’s hard because of the damned annotation stuff: we could trivially move the handlers onto a tree of handlers if we could just control how the annotation is derived. A little extra challenge. :)

]]> By: Joseph Gutierrez http://anarchycreek.com/2009/10/26/doubledawgdare-5-pick-pick-pick/comment-page-1/#comment-453 Joseph Gutierrez Fri, 30 Oct 2009 16:28:18 +0000 http://anarchycreek.com/?p=882#comment-453 Keep them coming... Faster. Faster Question: How long does it take you to produce the cast? Keep them coming… Faster. Faster

Question: How long does it take you to produce the cast?

]]> By: EricSchaefer http://anarchycreek.com/2009/10/26/doubledawgdare-5-pick-pick-pick/comment-page-1/#comment-439 EricSchaefer Wed, 28 Oct 2009 18:47:29 +0000 http://anarchycreek.com/?p=882#comment-439 The result of this session looks very much like the text book case of a Visitor, doesn't it? The result of this session looks very much like the text book case of a Visitor, doesn’t it?

]]>